It's unusual to have error checking like (ret <= 0) in cases when
counting GPIO resources. In case when it's mandatory we propagate the
error (-ENOENT), otherwise we don't use the result.

This makes consistent behaviour across all possible variants called in
gpiod_count().

Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
 drivers/gpio/gpiolib-acpi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
index 9b37a3692b3f..d7a22c470312 100644
--- a/drivers/gpio/gpiolib-acpi.c
+++ b/drivers/gpio/gpiolib-acpi.c
@@ -1067,7 +1067,7 @@ int acpi_gpio_count(struct device *dev, const char 
*con_id)
                                        break;
                                }
                }
-               if (count >= 0)
+               if (count > 0)
                        break;
        }
 
@@ -1083,7 +1083,7 @@ int acpi_gpio_count(struct device *dev, const char 
*con_id)
                if (crs_count > 0)
                        count = crs_count;
        }
-       return count;
+       return count ? count : -ENOENT;
 }
 
 struct acpi_crs_lookup {
-- 
2.11.0

Reply via email to