Hi Alan, Quoting Alan Stern <st...@rowland.harvard.edu>:
On Wed, 15 Feb 2017, Gustavo A. R. Silva wrote:Add missing pre-increment to 'waitcount' variable used in do-while loop. Addresses-Coverity-ID: 1011631 Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/usb/storage/jumpshot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/storage/jumpshot.c b/drivers/usb/storage/jumpshot.c index 011e527..a26c4bb 100644 --- a/drivers/usb/storage/jumpshot.c +++ b/drivers/usb/storage/jumpshot.c @@ -313,7 +313,7 @@ static int jumpshot_write_data(struct us_data *us, // msleep(50); } - } while ((result != USB_STOR_TRANSPORT_GOOD) && (waitcount < 10)); + } while ((result != USB_STOR_TRANSPORT_GOOD) && (++waitcount < 10)); if (result != USB_STOR_TRANSPORT_GOOD) usb_stor_dbg(us, "Gah! Waitcount = 10. Bad write!?\n");This has already been reported and fixed. See http://marc.info/?l=linux-usb&m=148604164024557&w=2
Awesome. Thanks for the info. -- Gustavo A. R. Silva
