On 02/23/2017 05:43 PM, Andy Shevchenko wrote: > On Wed, Feb 22, 2017 at 12:23 PM, Eva Rachel Retuya <eraret...@gmail.com> > wrote: >> Add SPI driver that initializes SPI regmap for the adxl345 core driver. >> The driver supports the same functionality as I2C namely the x, y, z and >> scale readings. > >> --- a/drivers/iio/accel/Kconfig >> +++ b/drivers/iio/accel/Kconfig >> @@ -8,20 +8,26 @@ menu "Accelerometers" >> config ADXL345 >> tristate "Analog Devices ADXL345 3-Axis Digital Accelerometer Driver" >> depends on !(INPUT_ADXL34X=y || INPUT_ADXL34X=m) >> + depends on (I2C || SPI) >> select REGMAP >> select ADXL345_I2C if I2C >> + select ADXL345_SPI if SPI >> help >> Say Y here if you want to build support for the Analog Devices >> ADXL345 3-axis digital accelerometer. >> >> To compile this driver as a module, choose M here: the core >> module will be called adxl345_core and you will also get >> - adxl345_i2c for I2C. >> + adxl345_i2c for I2C and/or adxl345_spi for SPI. >> >> config ADXL345_I2C >> tristate >> select REGMAP_I2C >> >> +config ADXL345_SPI >> + tristate >> + select REGMAP_SPI > > Hmm... > I saw another pattern > > Library / core part is non-visible to user, while > SPI and I2C parts are selectable by user. > > Why do you use inverted pattern? What did I miss?
The first version of the patch used the other pattern SPI/I2C visible. Jonathan suggested this other pattern. I prefer the explicit SPI/I2C visible pattern, but in the end it doesn't really matter as long as both work.
