On 02/20, Leonard Crestez wrote: > Some drivers use sprintf to build clk connection id names but the clk > core will save those strings and occasionally print them back. Duplicate > the con_id strings instead of fixing all the users. > > Signed-off-by: Leonard Crestez <leonard.cres...@nxp.com> > --- > drivers/clk/clk.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > Some examples of using sprintf for con_id include: > drivers/mfd/omap-usb-host.c > drivers/tty/serial/samsung.c > sound/soc/fsl/fsl_asrc.c > > There are lots more. They are difficult to find and "fixing" them on the > consumer side requires nasty code to keep track of the allocated clkname.
Good catch. What about dev_id though? That could also have the same problem if some device is removed and we're still holding a reference to the kobject's name. This is probably more rare than what is happening here, but still seems possible that we might trip over that later. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
