On 2017/2/28 13:33, Jaegeuk Kim wrote: > On 02/28, Chao Yu wrote: >> On 2017/2/24 6:58, Jaegeuk Kim wrote: >>> @@ -2326,7 +2431,8 @@ void flush_nat_entries(struct f2fs_sb_info *sbi) >>> * entries, remove all entries from journal and merge them >>> * into nat entry set. >>> */ >>> - if (!__has_cursum_space(journal, nm_i->dirty_nat_cnt, NAT_JOURNAL)) >>> + if (cpc->reason == CP_UMOUNT || >> >> enabled_nat_bits(sbi, cpc) > > Thanks. > I added another patch to fix this.
I'm OK with this change. Thanks, :) Thanks, > >>From b15f7112c3daced4c7f70c4d5fcba9013743cb6b Mon Sep 17 00:00:00 2001 > From: Jaegeuk Kim <jaeg...@kernel.org> > Date: Mon, 27 Feb 2017 21:28:53 -0800 > Subject: [PATCH] f2fs: avoid to flush nat journal entries > > This patch adds a missing condition which flushes nat journal entries > unnecessarily introduced by: > > f2fs: add bitmaps for empty or full NAT blocks > > Signed-off-by: Chao Yu <yuch...@huawei.com> > Signed-off-by: Jaegeuk Kim <jaeg...@kernel.org> > --- > fs/f2fs/node.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c > index b3aead4c5a0f..94967171dee8 100644 > --- a/fs/f2fs/node.c > +++ b/fs/f2fs/node.c > @@ -2513,7 +2513,7 @@ void flush_nat_entries(struct f2fs_sb_info *sbi, struct > cp_control *cpc) > * entries, remove all entries from journal and merge them > * into nat entry set. > */ > - if (cpc->reason == CP_UMOUNT || > + if (enabled_nat_bits(sbi, cpc) || > !__has_cursum_space(journal, nm_i->dirty_nat_cnt, NAT_JOURNAL)) > remove_nats_in_journal(sbi); > >
