On Wed, Mar 01, 2017 at 09:54:07AM -0800, Linus Torvalds wrote: > On Wed, Mar 1, 2017 at 1:03 AM, Benjamin Tissoires > <benjamin.tissoi...@redhat.com> wrote: > > > > As Peter mentioned in the bug, there is a missing property on the kernel > > node (INPUT_PROP_BUTTONPAD). > > > > The thing is this property is solely driven in the current driver by the > > provided platform_data, so there is no way we ever set it through > > hid-rmi. I wonder how we missed that. > > > > Anyway, the good news is that the evemu record shows only one exportted > > button, so we can infer the property quite easily in the module. Would > > something like that work for you? > > > > From: Benjamin Tissoires <benjamin.tissoi...@redhat.com> > > Date: Wed, 1 Mar 2017 09:57:00 +0100 > > Subject: [PATCH] Input: rmi4 - f30: detect INPUT_PROP_BUTTONPAD from the > > button count > > Yes, this fixes the problem for me. My click-and-drag works again, so > you can add a > > Reported-and-tested-by: Linus Torvalds <torva...@linux-foundation.org> > > I see that Dmitry doesn't love the patch, but I'm assuming I'll get > that or something equivalent soon. In the meantime, I'll just keep it > on my laptop as a workaround.
Given that it does work for you just apply it. The objections I raised was more of a bikeshedding. Thanks. -- Dmitry
