On Fri, 2017-03-03 at 02:49 +0530, simran singhal wrote: > The following Coccinelle script was used to detect this: > @r@ > expression x; > void* e; > type T; > identifier f; > @@ > ( > *((T *)e) > > > > ((T *)x)[...] > > > > ((T*)x)->f > > > > - (T*) > e > )
NAK. Nice, but you still have to verify correctness before submitting these patches. > diff --git a/drivers/staging/lustre/lustre/mgc/mgc_request.c > b/drivers/staging/lustre/lustre/mgc/mgc_request.c [] > @@ -1034,7 +1034,7 @@ static int mgc_set_info_async(const struct lu_env *env, > struct obd_export *exp, > rc = sptlrpc_parse_flavor(val, &flvr); > if (rc) { > CERROR("invalid sptlrpc flavor %s to MGS\n", > - (char *)val); > + val); Try compiling this.