From: Jie Deng <jie.de...@synopsys.com> Date: Wed, 1 Mar 2017 12:00:25 +0800
> +static int xlgmac_init(struct xlgmac_pdata *pdata) > +{ > + struct net_device *netdev = pdata->netdev; > + struct xlgmac_hw_ops *hw_ops = &pdata->hw_ops; Please order local variable declarations from longest to shortest line. Please fix this in your entire submission. > + > +err_netdev_register: > +err_init: Avoid multiple error labels in the same exact location, by having only one which describes what the error path unwinds. For example, here you could say "err_free_netdev". Please fix this up in your entire submission.