Hi Andrew, On mer., mars 08 2017, Andrew Lunn <and...@lunn.ch> wrote:
> Hi Gregory [...] Thanks for your comments I will fix the typos and the wording. >> +#define USB_SBUSCFG 0x90 >> +#define USB_SBUSCFG_BAWR 0x6 >> +#define USB_SBUSCFG_BARD 0x3 >> +#define USB_SBUSCFG_AHBBRST 0x0 > > These three are all shifts. So i would suggest adding _SHIFT to the > end. Actually I removed it to fit in the 80 character... > >> + >> +/* BAWR = BARD = 3 : Align read/write bursts packets larger than 128 bytes >> */ >> +#define USB_SBUSCFG_BAWR_ALIGN_128B 0x3 >> +#define USB_SBUSCFG_BARD_ALIGN_128B 0x3 >> +/* AHBBRST = 3 : Align AHB Burst to INCR16 (64 bytes) */ >> +#define USB_SBUSCFG_AHBBRST_INCR16 0x3 > > You can then apply the shift here. ... but I didn't think to this trick. > >> + >> +#define USB_SBUSCFG_DEF_VAL ((USB_SBUSCFG_BAWR_ALIGN_128B << >> USB_SBUSCFG_BAWR) \ >> + | (USB_SBUSCFG_BARD_ALIGN_128B << USB_SBUSCFG_BARD) \ >> + | (USB_SBUSCFG_AHBBRST_INCR16 << USB_SBUSCFG_AHBBRST)) > > and this is then shorted. So I will do it in the v2. Thanks Gregory > > Andrew -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
