Re: [PATCH RFC 4/4] VMX: Expose the LA57 feature to VM

[Paolo Bonzini]

On 29/12/2016 10:26, Liang Li wrote:
> -             if (is_noncanonical_address(la))
> +             if (is_noncanonical_address(la, virt_addr_bits(ctxt)))

Using virt_addr_bits and get_virt_addr_bits is quite a mouthful.  What
about using instead a pair of functions like these:

bool is_noncanonical_address(struct kvm_vcpu *vcpu, u64 addr)
{
        return addr == get_canonical(addr, get_virt_addr_bits(vcpu));
}

bool emulate_is_noncanonical_address(struct x86_emulate_ctxt *ctxt,
                                     u64 addr)
{
        return addr == get_canonical(addr, virt_addr_bits(ctxt));
}


Paolo