Rusty Russell <[EMAIL PROTECTED]> writes: > On Wed, 2007-03-21 at 03:31 -0600, Eric W. Biederman wrote: >> Rusty Russell <[EMAIL PROTECTED]> writes: >> > -/* >> > - * The boot_gdt_table must mirror the equivalent in setup.S and is >> > - * used only for booting. >> > - */ >> >> It looks like you are killing a useful comment here for no good reason. > > Hi Eric, > > I think one has to look harder, then. There is no "equivalent in > setup.S": there is no setup.S, and it's certainly not clear what GDT > this "must mirror": it doesn't mirror any GDT at the moment.
see the gdt in: arch/i386/boot/setup.S > This leaves us with "is only used for booting". The name > "boot_gdt_table" and the code itself are pretty clear. > > A comment might well deserve to live here, but not this one 8) > > Hope that clarifies, Some of your confusion at least. If anything the comment should read these values are fixed by the boot protocol and we can't change them. Eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
