Hi, On 2017년 03월 13일 20:28, Hans de Goede wrote: > With the new more strict ACPI gpio code the dsdt's IoRestriction > flags are honored on gpiod_get, but in some dsdt's it is wrong, > so explicitly call gpiod_direction_input on the id gpio if > necessary. > > This fixes the following errors when the int3496 code is used > together with the new more strict ACPI gpio code: > > [ 2382.484415] gpio gpiochip1: (INT33FF:01): gpiochip_lock_as_irq: tried to > flag a GPIO set as output for IRQ > [ 2382.484425] gpio gpiochip1: (INT33FF:01): unable to lock HW IRQ 3 for IRQ > [ 2382.484429] genirq: Failed to request resources for INT3496:00 (irq 174) > on irqchip chv-gpio > [ 2382.484518] intel-int3496 INT3496:00: can't request IRQ for USB ID GPIO: > -22 > [ 2382.500359] intel-int3496: probe of INT3496:00 failed with error -22 > > Cc: Andy Shevchenko <andriy.shevche...@linux.intel.com> > Signed-off-by: Hans de Goede <hdego...@redhat.com> > --- > Changes in v2: > -Warn about firmware bug when the dsdt's IoRestriction does not allow input > Changes in v3: > -Use FW_BUG macro > -Group check together with gpiodesc error check > -Keep lines within 80 chars limit > --- > drivers/extcon/extcon-intel-int3496.c | 3 +++ > 1 file changed, 3 insertions(+)
Applied it. Thanks. -- Best Regards, Chanwoo Choi Samsung Electronics
