On 14/03/17 12:54, Arnd Bergmann wrote:
> This driver uses the MSI domain but has no strict dependency on PCI_MSI, so we
> may run into a build failure when CONFIG_GENERIC_MSI_IRQ_DOMAIN is disabled:
>
> drivers/irqchip/irq-mvebu-odmi.c:152:15: error: variable 'odmi_msi_ops' has
> initializer but incomplete type
> static struct msi_domain_ops odmi_msi_ops = {
> ^~~~~~~~~~~~~~
> drivers/irqchip/irq-mvebu-odmi.c:155:15: error: variable
> 'odmi_msi_domain_info' has initializer but incomplete type
> static struct msi_domain_info odmi_msi_domain_info = {
> ^~~~~~~~~~~~~~~
> drivers/irqchip/irq-mvebu-odmi.c:156:3: error: 'struct msi_domain_info' has
> no member named 'flags'
> .flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS),
> ^~~~~
> drivers/irqchip/irq-mvebu-odmi.c:156:12: error: 'MSI_FLAG_USE_DEF_DOM_OPS'
> undeclared here (not in a function)
> .flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS),
> ^~~~~~~~~~~~~~~~~~~~~~~~
> drivers/irqchip/irq-mvebu-odmi.c:156:39: error: 'MSI_FLAG_USE_DEF_CHIP_OPS'
> undeclared here (not in a function); did you mean 'MSI_FLAG_USE_DEF_DOM_OPS'?
>
> Selecting the option from this driver seems to solve this nicely, though I
> could
> not find any other instance of this in irqchip drivers.
>
> Signed-off-by: Arnd Bergmann <a...@arndb.de>
> Acked-by: Thomas Petazzoni <thomas.petazz...@free-electrons.com>
> ---
> Originally sent on Feb 14, but for some reason didn't make it into v4.11-rc2
> and is still needed to build some randconfig configurations.
Ah, my bad. I had it stashed, and must have messed up my branch at some
point. I'm queuing it now and I'll send a PR to Thomas with whatever is
left by the end of the week.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
