Hi Bryan, On Fri, 23 Mar 2007 13:46:57 +0800, Wu, Bryan wrote: > Changlogs: > > a) Fixed issues according to Jean's review. > b) Add MAINTAINS infomation > c) add I2C_HW_B_BLACKFIN to i2c-id.h
I2C_HW_B_* is traditionally used for drivers built on top of the i2c-algo-bit driver, which isn't the case of your driver, so it's a bit confusing. Please instead use: #define I2C_HW_BLACKFIN 0x190001 I hope we'll be able to get rid of these IDs soon, so we no longer have to care about this mess. Other than that I'm OK with the patch this time, I'll push it on my stack. I'll fix the ID issue myself, no need to resend. This also means that, from now on, any change to this driver should be provided as an incremental patch on top of this version. Thanks, -- Jean Delvare - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
