On Wed, Mar 22, 2017 at 1:57 PM, Dmitry Vyukov <[email protected]> wrote: > Two problems was reported with READ_ONCE_NOCHECK in arch_atomic_read: > 1. Andrey Ryabinin reported significant binary size increase > (+400K of text). READ_ONCE_NOCHECK is intentionally compiled to > non-inlined function call, and I counted 640 copies of it in my vmlinux. > 2. Arnd Bergmann reported a new splat of too large frame sizes. > > A single inlined KASAN check is very cheap, a non-inlined function > call with KASAN/KCOV instrumentation can easily be more expensive. > > Switch to READ_ONCE() in arch_atomic[64]_read(). > > Signed-off-by: Dmitry Vyukov <[email protected]> > Reported-by: Arnd Bergmann <[email protected]> > Reported-by: Andrey Ryabinin <[email protected]> > Cc: Mark Rutland <[email protected]> > Cc: Peter Zijlstra <[email protected]> > Cc: Will Deacon <[email protected]> > Cc: Andrey Ryabinin <[email protected]> > Cc: Andrew Morton <[email protected]> > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Signed-off-by: Dmitry Vyukov <[email protected]> >
Acked-by: Arnd Bergmann <[email protected]>
