On Thu, 23 Mar 2017 16:06:19 +0900 Masahiro Yamada <[email protected]> wrote:
> Hi Boris, > > 2017-03-23 6:09 GMT+09:00 Boris Brezillon > <[email protected]>: > > On Wed, 22 Mar 2017 23:07:19 +0900 > > Masahiro Yamada <[email protected]> wrote: > > > >> @@ -339,6 +352,7 @@ struct denali_nand_info { > >> int bbtskipbytes; > >> int max_banks; > >> unsigned int caps; > >> +#define DENALI_CAP_HW_ECC_FIXUP BIT(0) > > > > Can you move this definition outside of the struct denali_nand_info > > definition? > > > My idea was to put relevant macros close to the "caps" member. > Actually, "struct mmc_host" does similar. > > > If you do not like it, yes, I can move it. > Anyway, this is a matter of taste, > and I do not have a strong opinion about this. > > Indeed, I prefer when macro and struct definitions are clearly separated.
