* Dmitry Vyukov <dvyu...@google.com> wrote: > > Are just utterly disgusting that turn perfectly readable code into an > > unreadable, unmaintainable mess. > > > > You need to find some better, cleaner solution please, or convince me that > > no > > such solution is possible. NAK for the time being. > > Well, I can just write all functions as is. Does it better confirm to kernel > style?
I think writing the prototypes out as-is, properly organized, beats any of these macro based solutions. > [...] I've just looked at the x86 atomic.h and it uses macros for similar > purpose (ATOMIC_OP/ATOMIC_FETCH_OP), so I thought that must be idiomatic > kernel > style... Mind fixing those too while at it? And please squash any bug fixes and re-send a clean series against latest upstream or so. Thanks, Ingo