> -----Original Message----- > From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > ow...@vger.kernel.org] On Behalf Of kan.li...@intel.com > Sent: Thursday, March 23, 2017 1:26 PM > Subject: [PATCH 2/3] tools lib api fs: Add sysfs__write_int function ... > diff --git a/tools/lib/api/fs/fs.c b/tools/lib/api/fs/fs.c ... > + > +int sysfs__write_int(const char *entry, int value) > +{ > + char path[PATH_MAX]; > + const char *sysfs = sysfs__mountpoint(); > + > + if (!sysfs) > + return -1; > + > + snprintf(path, sizeof(path), "%s/%s", sysfs, entry); > + > + return filename__write_int(path, value);
In the unlikely event of an overflow, it would be safer to confirm that the string fit into the path array (by using scnprintf()?) before trying to open that path.
