Commit-ID:  c3a0bbc7ad7598dec5a204868bdf8a2b1b51df14
Gitweb:     http://git.kernel.org/tip/c3a0bbc7ad7598dec5a204868bdf8a2b1b51df14
Author:     Adrian Hunter <adrian.hun...@intel.com>
AuthorDate: Fri, 24 Mar 2017 14:15:52 +0200
Committer:  Arnaldo Carvalho de Melo <a...@redhat.com>
CommitDate: Mon, 27 Mar 2017 11:58:08 -0300

perf auxtrace: Fix no_size logic in addr_filter__resolve_kernel_syms()

Address filtering with kernel symbols incorrectly resulted in the error
"Cannot determine size of symbol" because the no_size logic was the wrong
way around.

Signed-off-by: Adrian Hunter <adrian.hun...@intel.com>
Tested-by: Andi Kleen <a...@linux.intel.com>
Cc: sta...@vger.kernel.org # v4.9+
Link: 
http://lkml.kernel.org/r/1490357752-27942-1-git-send-email-adrian.hun...@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <a...@redhat.com>
---
 tools/perf/util/auxtrace.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/util/auxtrace.c b/tools/perf/util/auxtrace.c
index c5a6e0b1..78bd632 100644
--- a/tools/perf/util/auxtrace.c
+++ b/tools/perf/util/auxtrace.c
@@ -1826,7 +1826,7 @@ static int addr_filter__resolve_kernel_syms(struct 
addr_filter *filt)
                filt->addr = start;
                if (filt->range && !filt->size && !filt->sym_to) {
                        filt->size = size;
-                       no_size = !!size;
+                       no_size = !size;
                }
        }
 
@@ -1840,7 +1840,7 @@ static int addr_filter__resolve_kernel_syms(struct 
addr_filter *filt)
                if (err)
                        return err;
                filt->size = start + size - filt->addr;
-               no_size = !!size;
+               no_size = !size;
        }
 
        /* The very last symbol in kallsyms does not imply a particular size */

Reply via email to