* Kirill A. Shutemov <[email protected]> wrote:
> On Tue, Mar 28, 2017 at 08:12:59AM +0200, Ingo Molnar wrote:
> >
> > * Kirill A. Shutemov <[email protected]> wrote:
> >
> > > +#if PTRS_PER_P4D > 1
> > > +
> > > +static void walk_p4d_level(struct seq_file *m, struct pg_state *st,
> > > pgd_t addr,
> > > + unsigned long P)
> >
> > Pretty ugly line break. Either don't break the line, or break it in a more
> > logical
> > place, like:
> >
> > static void
> > walk_p4d_level(struct seq_file *m, struct pg_state *st, pgd_t addr,
> > unsigned long P)
> >
> > > + start = (p4d_t *) pgd_page_vaddr(addr);
> >
> > The space between the type cast and the function invocation is not needed.
>
> Both style issues you have pointed to are inherited from handling of other
> page table levels.
>
> Do you want me to adjust them too?
Yes, pre-existing uncleanlinesses are not a reason to replicate them going
forward. Feel free to do it in a separate preparatory patch if the noise
is too large.
Thanks,
Ingo
