Christoph Hellwig writes: > This patch moves the die notifier handling to common code. Previous > various architectures had exactly the same code for it. Note that > the new code is compiled unconditionally, this should be understood > as an appel to the other architecture maintainer to implement > support for it aswell (aka sprinkling a notify_die or two in the > proper place)
Seems OK, although I think kprobes should not be using notify_die. The set of events that kprobes is interested in has no intersection at all with the set that any other consumer of the notify_die events is interested in, on any architecture. Furthermore, the multiplexing of the kprobes events through notify_die really serves no useful purpose. It just means that kprobe_exceptions_notify has to demultiplex the events with a switch statement. There is no significant common code for all events in kprobe_exceptions_notify, just a simple check whether the event happened in user mode. However, all that is in arch code so can be changed per-arch if desired. Paul. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
