Hi, On 28 March 2017 at 21:42, Felipe Balbi <[email protected]> wrote: > > Hi, > > Baolin Wang <[email protected]> writes: >> Since usb phy core has added common code to register or unregister >> extcon device, then phy-qcom-8x16-usb driver does not need its own >> code to register/unregister extcon device, then remove them. >> >> Signed-off-by: Baolin Wang <[email protected]> > > so previous patch helped *ONE* single user? Was it really beneficial if > it's all for a single user? Which duplicated code did it remove?
Now only 3 USB phy drivers (phy-qcom-8x16-usb.c, phy-omap-otg.c and phy-msm-usb.c) had registered an extcon, mostly did not. phy-omap-otg.c did not add one usb phy, so I did not convert it. phy-msm-usb.c had 2 separate extcon devices, but my last patch did not support separate extcon devices which need to modify again. Moreover in future usb phy drivers do not need to implement extcon things in their own drivers. -- Baolin.wang Best Regards
