On Fri, Mar 31, 2017 at 04:10:09PM +0200, Greg KH wrote: > On Fri, Mar 31, 2017 at 09:31:09PM +0800, Wu Hao wrote: > > > On Thu, Mar 30, 2017 at 08:08:02PM +0800, Wu Hao wrote: > > > > +#include <linux/device.h> > > > > +#include <linux/module.h> > > > > +#include <linux/slab.h> > > > > +#include <linux/fpga/fpga-dev.h> > > > > + > > > > +static DEFINE_IDA(fpga_dev_ida); > > > > +static struct class *fpga_dev_class; > > > > + > > > > +static ssize_t name_show(struct device *dev, > > > > + struct device_attribute *attr, char *buf) { > > > > + struct fpga_dev *fdev = to_fpga_dev(dev); > > > > + > > > > + return sprintf(buf, "%s\n", fdev->name); } static > > > > +DEVICE_ATTR_RO(name); > > > > > > There already is a name for the device, it's the directory name. > > > > For current implementation, the directory will have a common name like > > > > /sys/class/fpga/fpga.0 > > /sys/class/fpga/fpga.1 > > /sys/class/fpga/fpga.2 > > ... > > > > For the 'name' sysfs interface, driver can put more device specific info > > into this 'name', e.g intel-fpga-dev. Userspace can use this information > > to know which kind of FPGA device it is. e.g if applications read the > > /sys/class/fpga/fpga.5/name as intel-fpga-dev, it means the 5th fpga > > device on the system is a Intel FPGA device, and then application applies > > related method to enumerate the accelerators for it. > > And other existing fpga class has similar sysfs interface too, so I would > > like to keep it aligned with others. > > Ok, then document the heck out of this in Documentation/ABI/ which I > don't think you did for the sysfs files you are creating.
Sure, thanks a lot for the reminder. I will prepare the sysfs docs in the next version. Thanks Hao > > thanks, > > greg k-h > -- > To unsubscribe from this list: send the line "unsubscribe linux-fpga" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html