On 01/04/17 15:11, simran singhal wrote: > The following Coccinelle script was used to detect this: > @r@ > expression x; > void* e; > type T; > identifier f; > @@ > ( > *((T *)e) > | > ((T *)x)[...] > | > ((T*)x)->f > | > - (T*) > e > ) > > Signed-off-by: simran singhal <singhalsimr...@gmail.com> It could be argued for this one that it is acting as documentation as it might not be obvious without looking up the definition of the iio_get_time_ns function that it takes a struct iio_dev.
However, on balance I think that this case is simple enough that it should be fine as you have it. Applied. > --- > drivers/iio/dac/ad5504.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/dac/ad5504.c b/drivers/iio/dac/ad5504.c > index 22a027d..712d86b 100644 > --- a/drivers/iio/dac/ad5504.c > +++ b/drivers/iio/dac/ad5504.c > @@ -223,7 +223,7 @@ static irqreturn_t ad5504_event_handler(int irq, void > *private) > 0, > IIO_EV_TYPE_THRESH, > IIO_EV_DIR_RISING), > - iio_get_time_ns((struct iio_dev *)private)); > + iio_get_time_ns(private)); > > return IRQ_HANDLED; > } >
