Tony, All, On Mon, Apr 3, 2017 at 10:46 AM, Geert Uytterhoeven <[email protected]> wrote: > > Hi Tony, > > On Thu, Mar 30, 2017 at 6:16 PM, Tony Lindgren <[email protected]> wrote: > > Recent pinctrl changes to allow dynamic allocation of pins exposed one > > more issue with the pinctrl pins claimed early by the controller itself. > > This caused a regression for IMX6 pinctrl hogs. > > > > Before enabling the pin controller driver we need to wait until it has > > been properly initialized, then claim the hogs, and only then enable it. > > > > To fix the regression, split the code into pinctrl_claim_hogs() and > > pinctrl_enable(). And then let's require that pinctrl_enable() is always > > called by the pin controller driver when ready after calling > > pinctrl_register_and_init(). > > > > Depends-on: 950b0d91dc10 ("pinctrl: core: Fix regression caused by delayed > > work for hogs") > > Fixes: df61b366af26 ("pinctrl: core: Use delayed work for hogs") > > Fixes: e566fc11ea76 ("pinctrl: imx: use generic pinctrl helpers for > > managing groups") > > Cc: Fabio Estevam <[email protected]> > > Cc: Gary Bisson <[email protected]> > > Cc: Geert Uytterhoeven <[email protected]> > > Cc: Haojian Zhuang <[email protected]> > > Cc: Masahiro Yamada <[email protected]> > > Cc: Mika Penttilä <[email protected]> > > Cc: Mika Westerberg <[email protected]> > > Cc: Nishanth Menon <[email protected]> > > Cc: Shawn Guo <[email protected]> > > Cc: Stefan Agner <[email protected]> > > Signed-off-by: Tony Lindgren <[email protected]> > > The display on r8a7740-armadillo800eva still works, so the GPIO hog > needed for that is OK. > > Tested-by: Geert Uytterhoeven <[email protected]>
For imx, tested on a Nitrogen6x platform: Before the patch: # dmesg | grep iomux [ 0.096672] imx6q-pinctrl 20e0000.iomuxc: unable to find group for node hoggrp [ 0.097215] imx6q-pinctrl 20e0000.iomuxc: initialized IMX pinctrl driver After the patch: # dmesg | grep iomux [ 0.097505] imx6q-pinctrl 20e0000.iomuxc: initialized IMX pinctrl driver Also, checking the pinctrl of the hog pins in sysfs proved to be correct. Tested-by: Gary Bisson <[email protected]> Regards, Gary
