Hi, "Gustavo A. R. Silva" <[email protected]> writes: > Code refactoring to make the flow easier to follow. > > Cc: Alan Stern <[email protected]> > Cc: Greg Kroah-Hartman <[email protected]> > Signed-off-by: Gustavo A. R. Silva <[email protected]> > --- > drivers/usb/misc/usbtest.c | 67 > +++++++++++++++++++++------------------------- > 1 file changed, 30 insertions(+), 37 deletions(-) > > diff --git a/drivers/usb/misc/usbtest.c b/drivers/usb/misc/usbtest.c > index 7bfb6b78..382491e 100644 > --- a/drivers/usb/misc/usbtest.c > +++ b/drivers/usb/misc/usbtest.c > @@ -124,18 +124,32 @@ static struct usb_device *testdev_to_usbdev(struct > usbtest_dev *test) > > /*-------------------------------------------------------------------------*/ > > +static inline void endpoint_update(int edi, > + struct usb_host_endpoint **in, > + struct usb_host_endpoint **out, > + struct usb_host_endpoint *e) > +{ > + if (edi) { > + if (!*in) > + *in = e; > + } else { > + if (!*out) > + *out = e; > + } > +} > + > static int > get_endpoints(struct usbtest_dev *dev, struct usb_interface *intf) > { > - int tmp; > - struct usb_host_interface *alt; > - struct usb_host_endpoint *in, *out; > - struct usb_host_endpoint *iso_in, *iso_out; > - struct usb_host_endpoint *int_in, *int_out; > - struct usb_device *udev; > + int tmp; > + struct usb_host_interface *alt; > + struct usb_host_endpoint *in, *out; > + struct usb_host_endpoint *iso_in, *iso_out; > + struct usb_host_endpoint *int_in, *int_out; > + struct usb_device *udev;
unnecessary change
>
> for (tmp = 0; tmp < intf->num_altsetting; tmp++) {
> - unsigned ep;
> + unsigned ep;
unnecessary change
>
> in = out = NULL;
> iso_in = iso_out = NULL;
> @@ -150,48 +164,27 @@ get_endpoints(struct usbtest_dev *dev, struct
> usb_interface *intf)
> * ignore other endpoints and altsettings.
> */
> for (ep = 0; ep < alt->desc.bNumEndpoints; ep++) {
> - struct usb_host_endpoint *e;
> + struct usb_host_endpoint *e;
unnecessary change
--
balbi
signature.asc
Description: PGP signature
