On Thu, Apr 06, 2017 at 07:12:42PM +0200, Michal Hocko wrote: > > ---8<--- > > mm, vmscan: prevent kswapd sleeping prematurely due to mismatched > > classzone_idx -fix > > > > The patch "mm, vmscan: prevent kswapd sleeping prematurely due to mismatched > > classzone_idx" has different initial starting conditions when kswapd > > is asleep. kswapd initialises it properly when it starts but the patch > > initialises kswapd_classzone_idx early and trips on a warning in > > free_area_init_node. This patch leaves the kswapd_classzone_idx as zero > > and defers to kswapd to initialise it properly when it starts. > > It will start during the online phase which is later than this physical > memory hotadd. >
Good, that's what appeared to be happening at least. It would be somewhat insane if kswapd was running before zones were initialised. > > This is a fix to the mmotm patch > > mm-vmscan-prevent-kswapd-sleeping-prematurely-due-to-mismatched-classzone_idx.patch > > > > Signed-off-by: Mel Gorman <mgor...@suse.de> > > Yes, that is what I would expect. Feel free to add > Acked-by: Michal Hocko <mho...@suse.com> > > if this is routed as a separate patch. Although I expect Andrew will > fold it into the original patch. > I added the ack anyway and resent the patch so it doesn't get lost in the middle of a thread. Thanks. -- Mel Gorman SUSE Labs
