Em Thu, Apr 06, 2017 at 09:51:51AM +0200, Christian Borntraeger escreveu:
> since 4.10 perf annotate exits on s390 with an "unknown error -95".
> Turns out that commit 786c1b51844d ("perf annotate: Start supporting
> cross arch annotation") added a hard requirement for architectureArgh, that was unfortunate, I'll apply your patches and try to remove that restriction, using the defaults previously in place :-\ thanks, - Arnaldo > support when objdump is used but only provided x86 and arm > support. Meanwhile power was added so lets add s390 as well. > > While at it make sure to implement the branch and jump types. > > Signed-off-by: Christian Borntraeger <[email protected]> > Fixes: 786c1b51844 "perf annotate: Start supporting cross arch annotation" > Cc: Arnaldo Carvalho de Melo <[email protected]> > --- > tools/perf/util/annotate.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c > index 273f21f..7aa5722 100644 > --- a/tools/perf/util/annotate.c > +++ b/tools/perf/util/annotate.c > @@ -130,6 +130,12 @@ static struct arch architectures[] = { > .name = "powerpc", > .init = powerpc__annotate_init, > }, > + { > + .name = "s390", > + .objdump = { > + .comment_char = '#', > + }, > + }, > }; > > static void ins__delete(struct ins_operands *ops) > -- > 2.7.4
