Re: [PATCHv2] x86/intel_rdt: Add cpus_list rdtgroup file

[Thomas Gleixner]

On Sun, 9 Apr 2017, Fenghua Yu wrote:
> >     rdtgrp = rdtgroup_kn_lock_live(of->kn);
> >  
> > -   if (rdtgrp)
> > -           seq_printf(s, "%*pb\n", cpumask_pr_args(&rdtgrp->cpu_mask));
> > -   else
> > +   if (rdtgrp) {
> > +           seq_printf(s, is_list(of) ? "%*pbl\n" : "%*pb\n",
> > +                      cpumask_pr_args(&rdtgrp->cpu_mask));
> > +   } else
> 
> Unbalanced braces around if-else. You can remove the { and } after if.

Wrong. I've explained that a gazillion of times already.

http://lkml.kernel.org/r/alpine.DEB.2.20.1701171956290.3645@nanos

So yes, the else path wants braces.

Thanks,

        tglx