On Mon 10-04-17 17:22:28, Michal Hocko wrote:
[...]
> Heh, this one is embarrassing
> diff --git a/drivers/base/memory.c b/drivers/base/memory.c
> index 1c6fdacbccd3..9677b6b711b0 100644
> --- a/drivers/base/memory.c
> +++ b/drivers/base/memory.c
> @@ -402,7 +402,7 @@ static ssize_t show_valid_zones(struct device *dev,
> return sprintf(buf, "none\n");
>
> start_pfn = valid_start_pfn;
> - nr_pages = valid_end_pfn - valid_end_pfn;
> + nr_pages = valid_end_pfn - start_pfn;
>
> /*
> * Check the existing zone. Make sure that we do that only on the
Btw. while starting into the code I think that allow_online_pfn_range is
also wrong and we need the following
diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
index 94e96ca790f6..035165ceefef 100644
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -858,7 +858,7 @@ bool allow_online_pfn_range(int nid, unsigned long pfn,
unsigned long nr_pages,
* TODO make sure we do not overlap with ZONE_DEVICE
*/
if (online_type == MMOP_ONLINE_KERNEL) {
- if (!populated_zone(movable_zone))
+ if (!movable_zone->spanned_pages)
return true;
return movable_zone->zone_start_pfn >= pfn + nr_pages;
} else if (online_type == MMOP_ONLINE_MOVABLE) {
because we would allow ZONE_NORMAL after the full movable zone has been
offlined.
--
Michal Hocko
SUSE Labs
