'stuser_create' returns an error pointer in case of error, not NULL.
So test its return value with IS_ERR.

Fixes: 74004262f329 ("MicroSemi Switchtec management interface driver")

Signed-off-by: Christophe JAILLET <[email protected]>
---
 drivers/pci/switch/switchtec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/switch/switchtec.c b/drivers/pci/switch/switchtec.c
index fcde98161d9a..cc6e085008fb 100644
--- a/drivers/pci/switch/switchtec.c
+++ b/drivers/pci/switch/switchtec.c
@@ -608,7 +608,7 @@ static int switchtec_dev_open(struct inode *inode, struct 
file *filp)
        stdev = container_of(inode->i_cdev, struct switchtec_dev, cdev);
 
        stuser = stuser_create(stdev);
-       if (!stuser)
+       if (IS_ERR(stuser))
                return PTR_ERR(stuser);
 
        filp->private_data = stuser;
-- 
2.11.0

Reply via email to