On Mon 2017-04-10 21:00:35, Aleksey Makarov wrote: > > > On 04/10/2017 05:22 PM, Petr Mladek wrote: > >On Wed 2017-04-05 23:20:00, Aleksey Makarov wrote: > >>If a console was specified by ACPI SPCR table _and_ command line > >>parameters like "console=ttyAMA0" _and_ "earlycon" were specified, > >>then log messages appear twice. > >> > >>The root cause is that the code traverses the list of specified > >>consoles (the `console_cmdline` array) and stops at the first match. > >>But it may happen that the same console is referred by the elements > >>of this array twice: > >> > >> pl011,mmio,0x87e024000000,115200 -- from SPCR > >> ttyAMA0 -- from command line > >> > >>but in this case `preferred_console` points to the second entry and > >>the flag CON_CONSDEV is not set, so bootconsole is not deregistered. > >> > >>To fix that, introduce an invariant "The last non-braille console > >>is always the preferred one" on the entries of the console_cmdline > >>array. Then traverse it in reverse order to be sure that if > >>the console is preferred then it will be the first matching entry. > >>Introduce variable console_cmdline_cnt that keeps the number > >>of elements of the console_cmdline array (Petr Mladek). It helps > >>to get rid of the loop that searches for the end of this array. > >> > >>Reported-by: Sudeep Holla <sudeep.ho...@arm.com> > >>Signed-off-by: Aleksey Makarov <aleksey.maka...@linaro.org> > > > >This version looks fine to me. Just a small nitpick below. > >Anyway: > > > >Reviewed-by: Petr Mladek <pmla...@suse.com> > > Thank you for review. Can you (or anybody else) ACK it? > I am going to resend the whole series without those empty lines. > May I add your Acked-by:?
Sure. Feel free to use: Acked-by: Petr Mladek <pmla...@suse.com> The meaning of the tags is a bit unclear. Acked-by means that the maintainer agrees with the idea. But it does not necessarily means that she reviewed the code in details. I agree with the idea and did the review, so I used the Reviewed-by tag. Also you do not need to resend the patchset just because the two empty lines. Sergey agrees. I will wait day or two and push all three patches into the printk.git if nobody complains in the meantime. I could remove the two empty lines when doing so. Thanks a lot for the fix and patience. Best Regards, Petr
