On Tue, Apr 11, 2017 at 7:19 PM, Leonard Crestez <leonard.cres...@nxp.com> wrote: > On Wed, 2017-04-12 at 12:03 +0800, Dong Aisheng wrote: >> +/** >> + * clk_bulk_enable - ungate a bulk of clocks >> + * @num_clks: the number of clk_bulk_data >> + * @clks: the clk_bulk_data table being ungated >> + * >> + * clk_bulk_enable must not sleep >> + * Returns 0 on success, -EERROR otherwise. >> + */ >> +int clk_bulk_enable(int num_clks, struct clk_bulk_data *clks) >> +{ >> + int ret; >> + int i; >> + >> + for (i = 0; i < num_clks; i++) { >> + ret = clk_enable(clks[i].clk); >> + if (ret) { >> + pr_err("Failed to enable clk '%s': %d\n", >> + clks[i].id, ret); >> + goto err; >> + } >> + } >> + >> + return 0; >> + >> +err: >> + while (--i >= 0) >> + clk_put(clks[i].clk); > > Shouldn't this be clk_disable? > > And you can probably use clk_bulk_disable(i, clks) instead
To avoid nasty surprises, clk_bulk_disable() should loop over all clocks in reverse order. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds