tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git WIP.hotplug
head:   355d9c03df2c702f4fc346b94b8d3dfa5992aa65
commit: 295afd420469ed67ea4c5c4b3fdf1bba5331f33e [30/32] PCI: Use 
cpu_hotplug_disable() instead of get_online_cpus()
config: x86_64-randconfig-x007-201715 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        git checkout 295afd420469ed67ea4c5c4b3fdf1bba5331f33e
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   In file included from include/uapi/linux/stddef.h:1:0,
                    from include/linux/stddef.h:4,
                    from include/uapi/linux/posix_types.h:4,
                    from include/uapi/linux/types.h:13,
                    from include/linux/types.h:5,
                    from include/linux/mod_devicetable.h:11,
                    from include/linux/pci.h:20,
                    from drivers/pci/pci-driver.c:11:
   drivers/pci/pci-driver.c: In function 'pci_call_probe':
   drivers/pci/pci-driver.c:342:27: error: 'struct pci_dev' has no member named 
'physfn'; did you mean 'is_physfn'?
     if (dev->is_virtfn && dev->physfn->is_probed)
                              ^
   include/linux/compiler.h:160:30: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                 ^~~~
>> drivers/pci/pci-driver.c:342:2: note: in expansion of macro 'if'
     if (dev->is_virtfn && dev->physfn->is_probed)
     ^~
   drivers/pci/pci-driver.c:342:27: error: 'struct pci_dev' has no member named 
'physfn'; did you mean 'is_physfn'?
     if (dev->is_virtfn && dev->physfn->is_probed)
                              ^
   include/linux/compiler.h:160:42: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                             ^~~~
>> drivers/pci/pci-driver.c:342:2: note: in expansion of macro 'if'
     if (dev->is_virtfn && dev->physfn->is_probed)
     ^~
   drivers/pci/pci-driver.c:342:27: error: 'struct pci_dev' has no member named 
'physfn'; did you mean 'is_physfn'?
     if (dev->is_virtfn && dev->physfn->is_probed)
                              ^
   include/linux/compiler.h:171:16: note: in definition of macro '__trace_if'
      ______r = !!(cond);     \
                   ^~~~
>> drivers/pci/pci-driver.c:342:2: note: in expansion of macro 'if'
     if (dev->is_virtfn && dev->physfn->is_probed)
     ^~

vim +/if +342 drivers/pci/pci-driver.c

   326          int error, node, cpu;
   327          struct drv_dev_and_id ddi = { drv, dev, id };
   328  
   329          /*
   330           * Execute driver initialization on node where the device is
   331           * attached.  This way the driver likely allocates its local 
memory
   332           * on the right node.
   333           */
   334          node = dev_to_node(&dev->dev);
   335          dev->is_probed = 1;
   336  
   337          cpu_hotplug_disable();
   338          /*
   339           * Prevent nesting work_on_cpu() for the case where a Virtual 
Function
   340           * device is probed from work_on_cpu() of the Physical device.
   341           */
 > 342          if (dev->is_virtfn && dev->physfn->is_probed)
   343                  cpu = nr_cpu_ids;
   344          else
   345                  cpu = cpumask_any_and(cpumask_of_node(node), 
cpu_online_mask);
   346  
   347          if (cpu < nr_cpu_ids)
   348                  error = work_on_cpu(cpu, local_pci_probe, &ddi);
   349          else
   350                  error = local_pci_probe(&ddi);

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

Reply via email to