On 2017-04-14 01:49, Dmitry Torokhov wrote:
> We should not be forcing edge triggered interrupt, but rather let platform
> decide the kind of trigger it needs to use. Also, the driver is not quite
> safe with regard to edge-triggered interrupts as it does not try to kick
> the controller after requesting/enabling IRQ.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torok...@gmail.com>
> ---
> drivers/input/touchscreen/ar1021_i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/ar1021_i2c.c
> b/drivers/input/touchscreen/ar1021_i2c.c
> index 6797e123925a..6c3c79b7ff51 100644
> --- a/drivers/input/touchscreen/ar1021_i2c.c
> +++ b/drivers/input/touchscreen/ar1021_i2c.c
> @@ -109,7 +109,7 @@ static int ar1021_i2c_probe(struct i2c_client *client,
>
> error = devm_request_threaded_irq(&client->dev, client->irq,
> NULL, ar1021_i2c_irq,
> - IRQF_TRIGGER_RISING | IRQF_ONESHOT,
> + IRQF_ONESHOT,
> "ar1021_i2c", ar1021);
> if (error) {
> dev_err(&client->dev,
>
makes sense, if users have to expect that this default can change. it works.
Tested-by: Martin Kepplinger <martin.kepplin...@ginzinger.com>
martin
