Commit-ID: a5cbdf693a60d5b86d4d21dfedd90f17754eb273 Gitweb: http://git.kernel.org/tip/a5cbdf693a60d5b86d4d21dfedd90f17754eb273 Author: Thomas Gleixner <t...@linutronix.de> AuthorDate: Wed, 12 Apr 2017 22:07:33 +0200 Committer: Thomas Gleixner <t...@linutronix.de> CommitDate: Sat, 15 Apr 2017 12:20:54 +0200
ACPI/processor: Fix error handling in __acpi_processor_start() When acpi_install_notify_handler() fails the cooling device stays registered and the sysfs files created via acpi_pss_perf_init() are leaked and the function returns success. Undo acpi_pss_perf_init() and return a proper error code. Signed-off-by: Thomas Gleixner <t...@linutronix.de> Cc: Fenghua Yu <fenghua...@intel.com> Cc: Tony Luck <tony.l...@intel.com> Cc: Herbert Xu <herb...@gondor.apana.org.au> Cc: "Rafael J. Wysocki" <r...@rjwysocki.net> Cc: Peter Zijlstra <pet...@infradead.org> Cc: Benjamin Herrenschmidt <b...@kernel.crashing.org> Cc: Sebastian Siewior <bige...@linutronix.de> Cc: Lai Jiangshan <jiangshan...@gmail.com> Cc: linux-a...@vger.kernel.org Cc: Viresh Kumar <viresh.ku...@linaro.org> Cc: Michael Ellerman <m...@ellerman.id.au> Cc: Tejun Heo <t...@kernel.org> Cc: "David S. Miller" <da...@davemloft.net> Cc: Len Brown <l...@kernel.org> Link: http://lkml.kernel.org/r/20170412201042.695499...@linutronix.de Signed-off-by: Thomas Gleixner <t...@linutronix.de> --- drivers/acpi/processor_driver.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/acpi/processor_driver.c b/drivers/acpi/processor_driver.c index 9d5f0c7..eab8cda 100644 --- a/drivers/acpi/processor_driver.c +++ b/drivers/acpi/processor_driver.c @@ -251,6 +251,9 @@ static int __acpi_processor_start(struct acpi_device *device) if (ACPI_SUCCESS(status)) return 0; + result = -ENODEV; + acpi_pss_perf_exit(pr, device); + err_power_exit: acpi_processor_power_exit(pr); return result;
