On Tue, Apr 18, 2017 at 09:51:31AM +0200, Martin Kaiser wrote:
> Thus wrote Greg Kroah-Hartman (gre...@linuxfoundation.org):
>
> > > - ret = proc_create("misc", 0, NULL, &misc_proc_fops);
> > > + ret = proc_create("misc", 0444, NULL, &misc_proc_fops);
>
> > What checkpatch warning does this fix? 0 is a number :)
>
> ERROR: Use 4 digit octal (0777) not decimal permissions
> #285: FILE: drivers/char/misc.c:285:
> + ret = proc_create("misc", 0, NULL, &misc_proc_fops);
Come on now, think about what this is saying. Is 0 not also an octal
number?
checkpatch requires you to use your brain, it is but a dumb perl
script...
greg k-h
