Re: [patch V2 08/10] timer: Implement the hierarchical pull model

[Peter Zijlstra]

On Tue, Apr 18, 2017 at 01:11:10PM +0200, Thomas Gleixner wrote:
> @@ -1689,11 +1708,16 @@ static void run_timer_base(int index, bo
>   */
>  static __latent_entropy void run_timer_softirq(struct softirq_action *h)
>  {
> +     struct timer_base *base = this_cpu_ptr(&timer_bases[BASE_LOCAL]);

Does this want to be inside the IS_ENABLED() block below? It seems to me
this could generate an unused variable warning for !NO_HZ_COMMON
compiler.

> +
>       run_timer_base(BASE_LOCAL, false);
>  
>       if (IS_ENABLED(CONFIG_NO_HZ_COMMON)) {
>               run_timer_base(BASE_GLOBAL, false);
>               run_timer_base(BASE_DEF, true);
> +
> +             if (base->nohz_active)
> +                     tmigr_handle_remote();
>       }
>  }