On 19/04/17 14:32, Dan Carpenter wrote: > On Wed, Apr 19, 2017 at 01:16:13PM +0100, Colin King wrote: >> From: Colin Ian King <colin.k...@canonical.com> >> >> ebus is being NULL checked however it is being dereferenced >> earlier on the assignment bus = ebus_to_hbus(ebus). Fix this >> by moving the assignment to after the NULL check on ebus to >> avoid a NULL pointer dereference error. >> > > ebus_to_hbus() doesn't dereference "ebus" it just uses it for pointer > math. > > #define ebus_to_hbus(ebus) (&(ebus)->bus) > > If you pass a NULL to there, it returns an offset starting from NULL but > it doesn't Oops.
Doh, brown paper bag moment for me. > > regards, > dan carpenter > >
