On Sat, 15 Apr 2017, Tony Lindgren wrote:

> The idle mode needs to be only disabled for UTMIAUTOIDLE while
> ULPIAUTOIDLE can be enabled.
> 
> This matches the TLL_CHANNEL_CONF_i register configuration for ehci-tll
> in the Motorola Linux kernel tree for Wrigley 3G LTE modem on droid 4
> and the modem still stays responsive.
> 
> Cc: Felipe Balbi <[email protected]>
> Cc: Keshava Munegowda <[email protected]>
> Cc: Marcel Partap <[email protected]>
> Cc: Michael Scott <[email protected]>
> Cc: Roger Quadros <[email protected]>
> Cc: Sebastian Reichel <[email protected]>
> Signed-off-by: Tony Lindgren <[email protected]>
> ---
>  drivers/mfd/omap-usb-tll.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c
> --- a/drivers/mfd/omap-usb-tll.c
> +++ b/drivers/mfd/omap-usb-tll.c
> @@ -373,12 +373,13 @@ int omap_tll_init(struct usbhs_omap_platform_data 
> *pdata)
>                       } else if (pdata->port_mode[i] ==
>                                       OMAP_EHCI_PORT_MODE_TLL) {
>                               /*
> -                              * Disable AutoIdle, BitStuffing
> -                              * and use SDR Mode
> +                              * Disable UTMI AutoIdle, BitStuffing
> +                              * and use SDR Mode. Enable ULPI AutoIdle.
>                                */
>                               reg &= ~(OMAP_TLL_CHANNEL_CONF_UTMIAUTOIDLE
>                                       | OMAP_TLL_CHANNEL_CONF_ULPIDDRMODE);
>                               reg |= OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF;
> +                             reg |= OMAP_TLL_CHANNEL_CONF_ULPI_ULPIAUTOIDLE;
>                       } else if (pdata->port_mode[i] ==
>                                       OMAP_EHCI_PORT_MODE_HSIC) {
>                               /*

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Reply via email to