Hi,
On Sat, Mar 31, 2007 at 10:24:12PM -0700, Pedram M wrote:
> How about this one? Am I doing it right now?
> If not, please try to explain more to me what I am
> doing wrong.
You have made several mistakes :
- you must select an appropriate subject for your mail. Nobody cares
that it is your first mail, what they care about is the problem you
are trying to fix and what it applies to. Preferably start your
subject with [PATCH] so that people can quickly notice it without
having to open it first.
- you did not send a description of your patch. It is important to
have a full description, it can be from 1 line to 1 page depending
on the complexity of the issue. It is important to explain why you
think you are right so that people can argue if they don't agree.
Please also try to be as factual as possible, because your message
will become the commit message. It means that sentences such as
"I think that ..." are not the best we can write.
- you must sign your patch. For this, add a "Signed-Off-By:" footer.
Take a look at other patches for this.
- your patch was cut and cannot apply to anything. A proper patch starts
with line beginning with "---" line, followed by a line with "+++",
both indicating the file your patch is supposed to apply to. Make your
patch with one level directory for the kernel so that it can apply with
"patch -p1". For instance:
$ diff -u linux-2.6.20/Makefile linux-2.6.20-mine/Makefile
Another solution is to use '.' as the directory, in order to add one
directory level for "patch -p1" to be happy :
$ diff -u ./Makefile.orig ./Makefile
Hoping this helps,
Willy
> @@ -4760,7 +4760,7 @@
> for (i = 0; i < NR_CARDS; i++) {
> /* look for a Cyclades card by vendor and device id */
> while ((device_id = cy_pci_dev_id[dev_index]) != 0) {
> - if ((pdev = pci_find_device(PCI_VENDOR_ID_CYCLADES,
> + if ((pdev = pci_get_device(PCI_VENDOR_ID_CYCLADES,
> device_id, pdev)) ==
> NULL) {
> dev_index++; /* try next device id */
> } else {
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [EMAIL PROTECTED]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
