On 1 May 2017 21:07:44 BST, Andy Shevchenko <[email protected]> wrote: >On Mon, May 1, 2017 at 10:48 PM, Jonathan Cameron ><[email protected]> wrote: >> On 1 May 2017 20:42:08 BST, Andy Shevchenko ><[email protected]> wrote: >>>On Mon, May 1, 2017 at 3:22 AM, Jonathan Cameron <[email protected]> >>>wrote: >>>> On 29/04/17 08:48, Eva Rachel Retuya wrote: >>> >>>>> +static int adxl345_set_mode(struct adxl345_data *data, u8 mode) >>>>> +{ >>>>> + struct device *dev = regmap_get_device(data->regmap); >>>>> + int ret; >>>>> + >>>>> + ret = regmap_write(data->regmap, ADXL345_REG_POWER_CTL, >mode); >>>>> + if (ret < 0) { >>>>> + dev_err(dev, "Failed to set power mode, %d\n", ret); >>>>> + return ret; >>>> drop the return ret here and just return ret at the end of the >>>function. >>>> One of the static checkers will probably moan about this otherwise. >>> >>>But this will be not equivalent! >> Why? Regmap_write returns 0 for success. > >If there is a qurantee that regmap_write() doesn't return any positive >values, I'm okay with replacement. Kernel doc says so.
>http://lxr.free-electrons.com/source/drivers/base/regmap/regmap.c#L1693 >>> >>>>> + } >>>>> + >>>>> + return 0; >>>>> +} -- Sent from my Android device with K-9 Mail. Please excuse my brevity.
