> > @@ -272,9 +292,9 @@ static int bl_get_brightness(struct backlight_device *b)
> > static int bl_update_status(struct backlight_device *b)
> > {
> > if (b->props.power == FB_BLANK_POWERDOWN)
> > - call_fext_func(FUNC_BACKLIGHT, 0x1, 0x4, 0x3);
> > + fext_backlight(0x1, 0x4, 0x3);
> > else
> > - call_fext_func(FUNC_BACKLIGHT, 0x1, 0x4, 0x0);
> > + fext_backlight(0x1, 0x4, 0x0);
> >
> > return set_lcd_level(b->props.brightness);
> > }
> > @@ -610,22 +630,22 @@ static int logolamp_set(struct led_classdev *cdev,
> > if (brightness < LED_FULL)
> > always = FUNC_LED_OFF;
> >
> > - ret = call_fext_func(FUNC_LEDS, 0x1, LOGOLAMP_POWERON, poweron);
> > + ret = fext_leds(0x1, LOGOLAMP_POWERON, poweron);
> > if (ret < 0)
> > return ret;
> >
> > - return call_fext_func(FUNC_LEDS, 0x1, LOGOLAMP_ALWAYS, always);
> > + return fext_leds(0x1, LOGOLAMP_ALWAYS, always);
> > }
>
> I've only just noticed this. For the led calls we have symbolic identifiers
> defined for the "features" parameter, but in the backlight case we are still
> using arbitrary numeric constants. Although not necessary for this patch
> set, we should consider adding feature identifiers for the other fext_*()
> calls.
> Similarly for the "op" parameter where it makes sense to do so.
Good point, I will keep that in mind for the next patch series.
--
Best regards,
Michał Kępień
