Hi,

some atomic operations are only atomic, not ordered. Thus a CPU is allowed
to reorder memory references to an object to before the reference is
obtained. This fixes it.

        Regards
                Oliver
Signed-off-by: Oliver Neukum <[EMAIL PROTECTED]>
------

--- a/lib/kref.c        2007-04-02 14:40:40.000000000 +0200
+++ b/lib/kref.c        2007-04-02 14:40:50.000000000 +0200
@@ -21,6 +21,7 @@
 void kref_init(struct kref *kref)
 {
        atomic_set(&kref->refcount,1);
+       smp_mb();
 }
 
 /**
@@ -31,6 +32,7 @@
 {
        WARN_ON(!atomic_read(&kref->refcount));
        atomic_inc(&kref->refcount);
+       smp_mb__after_atomic_inc();
 }
 
 /**
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to