Bastien Nocera <had...@hadess.net> writes:

> On Mon, 2017-05-01 at 18:52 -0600, Justin Vreeland wrote:
>> Ensure checkpatch compliance
>> 
>> > Signed-off-by: Justin Vreeland <jus...@jvreeland.com>
>> ---
>> v2:
>>   - Added commit message
>>   - Fixed overly long lines
>> 
>>  drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 18 ++++++++----------
>>  drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c | 12 ++++++------
>>  drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c  |  9 ++++-----
>>  3 files changed, 18 insertions(+), 21 deletions(-)
>> 
>> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c 
>> b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
>> index 28d1a229c3a6..21ec890fd60c 100644
>> --- a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
>> +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
>> @@ -385,8 +385,7 @@ s32 PHY_MACConfig8723B(struct adapter *Adapter)
>> >    /*  Config MAC */
>> >    /*  */
>> >    rtStatus = phy_ConfigMACWithParaFile(Adapter, pszMACRegFile);
>> > -  if (rtStatus == _FAIL)
>> > -  {
>> > +  if (rtStatus == _FAIL) {
>> >            ODM_ConfigMACWithHeaderFile(&pHalData->odmpriv);
>> >            rtStatus = _SUCCESS;
>> >    }
>> @@ -459,8 +458,7 @@ static int phy_BB8723b_Config_ParaFile(struct adapter 
>> *Adapter)
>> >            Adapter->registrypriv.RegEnableTxPowerLimit == 1 ||
>> >            (Adapter->registrypriv.RegEnableTxPowerLimit == 2 && 
>> > pHalData->EEPROMRegulatory == 1)
>> >    ) {
>> > -          if (PHY_ConfigRFWithPowerLimitTableParaFile(Adapter, 
>> > pszRFTxPwrLmtFile) == _FAIL)
>> > -          {
>> > +          if (PHY_ConfigRFWithPowerLimitTableParaFile(Adapter, 
>> > pszRFTxPwrLmtFile) == _FAIL) {
>> >                    if (HAL_STATUS_SUCCESS != 
>> > ODM_ConfigRFWithHeaderFile(&pHalData->odmpriv, CONFIG_RF_TXPWR_LMT, 
>> > (ODM_RF_RADIO_PATH_E)0))
>> >                            rtStatus = _FAIL;
>> >            }
>> @@ -474,8 +472,8 @@ static int phy_BB8723b_Config_ParaFile(struct adapter 
>> *Adapter)
>> >    /*  */
>> >    /*  1. Read PHY_REG.TXT BB INIT!! */
>> >    /*  */
>> > -  if (phy_ConfigBBWithParaFile(Adapter, pszBBRegFile, CONFIG_BB_PHY_REG) 
>> > == _FAIL)
>> > -  {
>> > +  if (phy_ConfigBBWithParaFile(Adapter, pszBBRegFile, CONFIG_BB_PHY_REG) 
>> > ==
>> +            _FAIL) {
>
> This and...
>
>>              if (HAL_STATUS_SUCCESS != 
>> ODM_ConfigBBWithHeaderFile(&pHalData->odmpriv, CONFIG_BB_PHY_REG))
>> >                    rtStatus = _FAIL;
>> >    }
>> @@ -491,8 +489,8 @@ static int phy_BB8723b_Config_ParaFile(struct adapter 
>> *Adapter)
>> >            Adapter->registrypriv.RegEnableTxPowerByRate == 1 ||
>> >            (Adapter->registrypriv.RegEnableTxPowerByRate == 2 && 
>> > pHalData->EEPROMRegulatory != 2)
>> >    ) {
>> > -          if (phy_ConfigBBWithPgParaFile(Adapter, pszBBRegPgFile) == 
>> > _FAIL)
>> > -          {
>> > +          if (phy_ConfigBBWithPgParaFile(Adapter, pszBBRegPgFile) ==
>> > +                  _FAIL) {
>> >                    if (HAL_STATUS_SUCCESS != 
>> > ODM_ConfigBBWithHeaderFile(&pHalData->odmpriv, CONFIG_BB_PHY_REG_PG))
>> >                            rtStatus = _FAIL;
>> >            }
>> @@ -514,8 +512,8 @@ static int phy_BB8723b_Config_ParaFile(struct adapter 
>> *Adapter)
>> >    /*  */
>> >    /*  2. Read BB AGC table Initialization */
>> >    /*  */
>> > -  if (phy_ConfigBBWithParaFile(Adapter, pszAGCTableFile, 
>> > CONFIG_BB_AGC_TAB) == _FAIL)
>> > -  {
>> > +  if (phy_ConfigBBWithParaFile(Adapter, pszAGCTableFile,
>> +                                 CONFIG_BB_AGC_TAB) == _FAIL) {
>
> ...this and the other such changes below are just way ugly, whatever
> the coding style says.

Reply via email to