On Thursday, May 11, 2017 04:27:19 PM Bartlomiej Zolnierkiewicz wrote: > > @@ -358,11 +358,7 @@ static int __init vrfb_probe(struct platform_device > > *pdev) > > return PTR_ERR(vrfb_base); > > > > num_ctxs = pdev->num_resources - 1; > > - > > - ctxs = devm_kzalloc(&pdev->dev, > > - sizeof(struct vrfb_ctx) * num_ctxs, > > - GFP_KERNEL); > > - > > + ctxs = devm_kcalloc(&pdev->dev, num_ctxs, sizeof(*ctxs), GFP_KERNEL); > > This change makes the resulting binary larger by 24 bytes (probably > because of the need to have an additional function argument) and
24 bytes seemed too much for just an additional function argument so I've checked the source: static inline void *devm_kzalloc(struct device *dev, size_t size, gfp_t gfp) { return devm_kmalloc(dev, size, gfp | __GFP_ZERO); } static inline void *devm_kmalloc_array(struct device *dev, size_t n, size_t size, gfp_t flags) { if (size != 0 && n > SIZE_MAX / size) return NULL; return devm_kmalloc(dev, n * size, flags); } static inline void *devm_kcalloc(struct device *dev, size_t n, size_t size, gfp_t flags) { return devm_kmalloc_array(dev, n, size, flags | __GFP_ZERO); } The extra kcalloc() checks are inlined currently into each instance. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics