On Thu, 11 May 2017 11:31:27 -0700 Eric Anholt <e...@anholt.net> wrote:
> drm_encoder_cleanup() finishes with memsetting it to 0, already. > > Signed-off-by: Eric Anholt <e...@anholt.net> Acked-by: Boris Brezillon <boris.brezil...@free-electrons.com> > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c > b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c > index 65a3bd7a0c00..4b2cfbd0d43f 100644 > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c > @@ -83,14 +83,8 @@ static const struct drm_encoder_helper_funcs > atmel_hlcdc_panel_encoder_helper_fu > .enable = atmel_hlcdc_rgb_encoder_enable, > }; > > -static void atmel_hlcdc_rgb_encoder_destroy(struct drm_encoder *encoder) > -{ > - drm_encoder_cleanup(encoder); > - memset(encoder, 0, sizeof(*encoder)); > -} > - > static const struct drm_encoder_funcs atmel_hlcdc_panel_encoder_funcs = { > - .destroy = atmel_hlcdc_rgb_encoder_destroy, > + .destroy = drm_encoder_cleanup, > }; > > static int atmel_hlcdc_panel_get_modes(struct drm_connector *connector)