On Wednesday, May 17, 2017 9:08:37 AM CEST Namhyung Kim wrote: > Currently "perf report -g srcline --stdio" shows two warnings like > below: > > Invalid callchain mode: srcline > Invalid callchain order: srcline > > This is because it always tries to parse callchain mode, order, sort-key > and value-type in a row. So even if 'srcline' is a valid sort-key, it > shows invalid mode and order warnings. > > Change it to show a warning only if failed to parse the given token as > any of valid parameter. Also code under try_numbers requires the token > to be a number, it's good to show the warning there. > > Cc: Milian Wolff <milian.wo...@kdab.com> > Cc: Frederic Weisbecker <fweis...@gmail.com> > Signed-off-by: Namhyung Kim <namhy...@kernel.org>
Thank you, that annoyed me too. Tested and reviewed it, works fine - thanks! Bye -- Milian Wolff | milian.wo...@kdab.com | Software Engineer KDAB (Deutschland) GmbH&Co KG, a KDAB Group company Tel: +49-30-521325470 KDAB - The Qt Experts
smime.p7s
Description: S/MIME cryptographic signature
