On Wed, May 17, 2017 at 11:26 PM, Yury Norov <yno...@caviumnetworks.com> wrote: > Hi Amir, > > (Sorry for new email, but I cannot find your patch in my mailbox, > though found it in next-20170517) > > Your patch 02cac3227a282 (ovl: mark upper dir with type origin entries > "impure") makes gcc warn on uninitialized variables in my arm64 build: > fs/overlayfs/dir.c: In function ‘ovl_rename’: > fs/overlayfs/dir.c:1060:2: warning: ‘newdentry’ may be used > uninitialized in this function [-Wmaybe-uninitialized] > dput(newdentry); > ^~~~~~~~~~~~~~~ > fs/overlayfs/dir.c:1062:2: warning: ‘olddentry’ may be used > uninitialized in this function [-Wmaybe-uninitialized] > dput(olddentry); > ^~~~~~~~~~~~~~~ > > The patch below fixes warnings for me. But I'm not familiar to the > subsystem and so not sure that the fix is correct. > It's not. Should be goto out_revert_creds;
Already sent a fix for that. Thanks!
