From: Babu Moger <babu.mo...@oracle.com> Date: Thu, 18 May 2017 18:36:05 -0600
> Seeing this error on SPARC while compiling qrwlock.c. > > CC kernel/locking/qrwlock.o > In file included from ./include/asm-generic/qrwlock_types.h:5, > from ./arch/sparc/include/asm/qrwlock.h:4, > from kernel/locking/qrwlock.c:24: > ./arch/sparc/include/asm/spinlock_types.h:5:3: error: > #error "please don't include this file directly" > > Re-arrange the includes in qrwlock_types.h and also include spinlock.h > in qrwlock.c to fix it. This should also help other architectures when > queued rwlock is enabled. > > Signed-off-by: Babu Moger <babu.mo...@oracle.com> > Reviewed-by: Håkon Bugge <haakon.bu...@oracle.com> > Reviewed-by: Jane Chu <jane....@oracle.com> > Reviewed-by: Shannon Nelson <shannon.nel...@oracle.com> > Reviewed-by: Vijay Kumar <vijay.ac.ku...@oracle.com> I think you can simply remove the: #ifndef __LINUX_SPINLOCK_TYPES_H # error "please don't include this file directly" #endif stanza from the sparc header file instead. Other architectures don't use this guard.
